Ignore 'property' decorator when transpiling function decorators#729
Open
AlexECX wants to merge 1 commit intoTranscryptOrg:dev_fall_2019from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Like the
classmethodandstaticmethoddecorators, thepropertydecorator is handled differently from other decorators and is not 'stacked' in front of the function it decorates. That is unless you combine it with other decorators, in which case it is added to the stack and will cause errors at JS runtime.This PR aims to exclude the
propertydecorator from the decorator stack, just likeclassmethodandstaticmethodalready are.Related issue number
Related to #658.
PR Checklist